From 8af878004dff4663b158108cac57bec05a4aa547 Mon Sep 17 00:00:00 2001 From: redxef Date: Tue, 16 Jan 2024 18:12:37 +0100 Subject: [PATCH] Shellcheck found some false positives in the printf hints. --- certbot-auth | 2 +- certbot-cleanup | 2 +- duckdns | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/certbot-auth b/certbot-auth index 5b8c94a..ae63d40 100755 --- a/certbot-auth +++ b/certbot-auth @@ -3,7 +3,7 @@ echo "certbot txt record: $CERTBOT_VALIDATION" baseurl='https://www.duckdns.org/update?domains=%s&token=%s&txt=%s' -result="$(printf 'url=%s\n' "$baseurl" "$DUCKDNS_DOMAIN" "$DUCKDNS_TOKEN" "$CERTBOT_VALIDATION" | curl -K -)" +result="$(printf "url=$baseurl\n" "$DUCKDNS_DOMAIN" "$DUCKDNS_TOKEN" "$CERTBOT_VALIDATION" | curl -K -)" # give some time for the record to update echo "waiting for txt record" diff --git a/certbot-cleanup b/certbot-cleanup index 54b3a5b..3e36536 100755 --- a/certbot-cleanup +++ b/certbot-cleanup @@ -1,4 +1,4 @@ #!/usr/bin/env sh baseurl='https://www.duckdns.org/update?domains=%s&token=%s&txt=&clear=True' -test "$(printf "url=%s\n" "$baseurl" "$DUCKDNS_DOMAIN" "$DUCKDNS_TOKEN" | curl -K -)" = 'OK' +test "$(printf "url=$baseurl\n" "$DUCKDNS_DOMAIN" "$DUCKDNS_TOKEN" | curl -K -)" = 'OK' diff --git a/duckdns b/duckdns index e4a8b8f..fab219e 100755 --- a/duckdns +++ b/duckdns @@ -2,4 +2,4 @@ logfile=/var/log/duckdns.log baseurl='https://www.duckdns.org/update?domains=%s&token=%s' -printf 'url=%s\n' "$baseurl" "$DUCKDNS_DOMAIN" "$DUCKDNS_TOKEN" | curl -o "$logfile" -K - +printf "url=$baseurl\n" "$DUCKDNS_DOMAIN" "$DUCKDNS_TOKEN" | curl -o "$logfile" -K -